Use find_by_sql instead of select_all and send(:instantiate)#57
Open
Use find_by_sql instead of select_all and send(:instantiate)#57
Conversation
zerowidth
approved these changes
Sep 23, 2021
Contributor
zerowidth
left a comment
There was a problem hiding this comment.
You'd know better than me!
These are both private APIs, but _load_from_sql will give us even more standard behaviour (this is what find_by_sql calls) including emitting the instantiation.active_record notification. This may be faster in some cases since _load_from_sql includes a fast path for when an inheritance column isn't present.
4f49155 to
597abcd
Compare
Contributor
Author
|
Updated to just call This move us to using a completely standard API 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are both private APIs, but _load_from_sql will give us even more standard behaviour (this is what find_by_sql calls) including emitting the instantiation.active_record notification.
This may be faster in some cases since _load_from_sql includes a fast path for when an inheritance column isn't present.