Conversation
For more predictable builds
Or reuse, as in test cases
Coupled with the migration, this allows for case sensitivity
No need to specify it separately
jcowhigjr
reviewed
Dec 13, 2021
| assert_equal "uppercase", @kv.get("FOO").value! | ||
| end | ||
|
|
||
| def test_get_and_set_case_insensitive |
There was a problem hiding this comment.
Suggested change
| def test_get_and_set_case_insensitive | |
| def test_get_and_set_case_sensitive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the bugfix in #53:
--table-nameto the migration generator and config (for easier use, and for use in tests)--case-sensitiveto the migration generator to update the KV table to use the case-sensitiveutf8_bincollation for thekeycolumn and table.config.case_sensitive = trueto enable case-sensitive behavior in the KV library.