Skip to content

Comments

remove incorrect reference to redirect_uri#34652

Closed
akorzynski wants to merge 1 commit intogithub:mainfrom
akorzynski:remove-incorrect-redirect_uri
Closed

remove incorrect reference to redirect_uri#34652
akorzynski wants to merge 1 commit intogithub:mainfrom
akorzynski:remove-incorrect-redirect_uri

Conversation

@akorzynski
Copy link

@akorzynski akorzynski commented Sep 19, 2024 •
edited
Loading

Why:

redirect_uri is not a parameter to the call that exchanges the OAuth2 code for the token. It's a parameter to an earlier call: the one that redirects the user back to the app.

Closes: #34651

What's being changed (if available, include any code snippets, screenshots, or gifs):

Removed the redirect_uri reference from the table containing the query parameters.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@akorzynski
remove incorrect reference to redirect_uri
3280ad7 
`redirect_uri` is **not** a parameter to the call that exchanges the OAuth2 code for the token. It's a parameter to an earlier call: the one that redirects the user back to the app.
@welcome
Copy link

welcome bot commented Sep 19, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/creating-github-apps/authenticating-with-a-github-app/generating-a-user-access-token-for-a-github-app.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
from reusable

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review github apps Content related to GitHub Apps and removed triage Do not begin working on this issue until triaged by the team labels Sep 19, 2024
@nguyenalex836
Copy link
Contributor

nguyenalex836 commented Sep 19, 2024

@akorzynski Thanks so much for opening a PR! I'll get this triaged for review ✨

@subatoi subatoi added the needs SME This proposal needs review from a subject matter expert label Sep 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836
Copy link
Contributor

nguyenalex836 commented Sep 20, 2024

@akorzynski Thank you for your patience while our SME team reviewed your PR!

After review, they responded with the following to whether redirect_uri is a parameter to the call that exchanges the OAuth2 code for the token -

Per RFC 6749 section 4.1.3 this is a valid use of the parameter. It is optional, as implied by the lack of a Required note. If included though it must match.

For this reason, we will close this PR 💛 Thank you for your willingness to contribute to our docs! ✨

@nguyenalex836 nguyenalex836 added SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Sep 20, 2024
@akorzynski
Copy link
Author

akorzynski commented Sep 23, 2024

Thank you for the specific response

bigbob78C
bigbob78C reviewed Feb 14, 2026
View reviewed changes
Copy link

@bigbob78C bigbob78C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The threats are always there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bigbob78C bigbob78C bigbob78C left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team github apps Content related to GitHub Apps SME reviewed An SME has reviewed this issue/PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove incorrect reference to redirect_uri

4 participants

@akorzynski @nguyenalex836 @bigbob78C @subatoi