Enable direct tracing the autobuild build mode by default#2353
Merged
henrymercer merged 7 commits intomainfrom Jul 10, 2024
Merged
Enable direct tracing the autobuild build mode by default#2353henrymercer merged 7 commits intomainfrom
henrymercer merged 7 commits intomainfrom
Conversation
…lsVersion` If no features have a `toolsVersion` property, we'll never hit those code paths, so it isn't that important to test them. Having a synthetic feature is an option but might create user confusion.
aeisenberg
reviewed
Jul 9, 2024
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Looks good. I'd say it's unlikely we'll ever need a minimum version feature again since we've moved to toolsVersion .
CHANGELOG.md
Outdated
| ## [UNRELEASED] | ||
|
|
||
| - Improve the reliability and performance of analyzing code when analyzing a compiled language with the `autobuild` [build mode](https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages#codeql-build-modes) on GitHub Enterprise Server. This feature is already available to GitHub.com users. [#2235](https://github.com/github/codeql-action/pull/2235) | ||
| No user facing changes. |
Contributor
There was a problem hiding this comment.
I think this line should be deleted.
Contributor
Author
There was a problem hiding this comment.
Thanks, this was a bad auto merge.
Contributor
Author
|
@angelapwen would you mind reviewing the last couple of commits so we can get this in? |
This was referenced Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge this once we've cut the final GHES 3.14 release.
This PR removes the feature flag for using direct tracing for the autobuild build mode, thereby enabling it for GHES.
Probably the most controversial change is removing the tests that require us to have at least one feature with a
minimumVersionandtoolsVersionproperty. I did this because if no features have atoolsVersionproperty, we'll never hit those code paths, so it isn't that important to test them. Having a synthetic feature is an option but might create user confusion.Merge / deployment checklist