Improve downloading log message#1920
Merged
angelapwen merged 1 commit intogithub:mainfrom Oct 5, 2023
Merged
Conversation
angelapwen
reviewed
Oct 4, 2023
Contributor
angelapwen
left a comment
There was a problem hiding this comment.
Thank you for the contribution @hoshinotsuyoshi ✨ You will need to run npm run build in order to regenerate the relevant transpilation files.
Regarding GitHub Actions log output, the dot was recognized as part of the URL.
d9c08be to
6fe4546
Compare
Contributor
Author
|
@angelapwen Thank you! force-pushed 6fe4546 . |
angelapwen
approved these changes
Oct 5, 2023
Contributor
angelapwen
left a comment
There was a problem hiding this comment.
Looks good! I will turn auto-merge on for when the PR checks pass 🥳
Contributor
|
The failing |
Contributor
|
I think it should be unrelated as the failure is |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding GitHub Actions log output, the dot was recognized as part of the URL.
Merge / deployment checklist