Skip to content

Port "C#: Set proxy environment variables, if Dependabot proxy is detected" to 2.20.0 release branch #18238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 15 commits into from
Dec 6, 2024
Merged

Port "C#: Set proxy environment variables, if Dependabot proxy is detected" to 2.20.0 release branch #18238

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a0cb9c1
C#: Add `CODEQL_PROXY_*` environment variable names
mbg Nov 11, 2024
459b76a
C#: Add `DependabotProxy` class
mbg Nov 11, 2024
c6f0895
C#: Initialise `DependabotProxy` in `DotNetCliInvoker`
mbg Nov 19, 2024
d6fda1a
C#: Set environment variables for proxy for calls to `dotnet`
mbg Nov 19, 2024
84d3532
C#: Add more logging to `DependabotProxy`
mbg Nov 29, 2024
4a7413c
C#: Use `Add` for environment variables
mbg Dec 2, 2024
8b5050e
C# Expose `CertificatePath` from `DependabotProxy`
mbg Dec 2, 2024
4d5c55e
C#: Propagate `DependabotProxy` instance down from `DependencyManager`
mbg Dec 2, 2024
8886292
C#: Set up proxy for `IsFeedReachable`, if configured
mbg Dec 2, 2024
174cb7c
C#: Load Dependabot Proxy certificate in `DependabotProxy`, and imple…
mbg Dec 3, 2024
2bb59e2
C#: Apply suggestions from code review for `DependabotProxy`
mbg Dec 5, 2024
1569621
C#: Don't initialise `DependabotProxy` on Windows or macOS
mbg Dec 5, 2024
671e61f
C#: Fix possible null dereference
mbg Dec 5, 2024
0d206bd
C#: Explicitly close writer in `DependabotProxy`
mbg Dec 6, 2024
32d757f
C#: Create certificate from string, rather than file
mbg Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
C#: Create certificate from string, rather than file
  • Loading branch information
@mbg
mbg committed Dec 6, 2024
commit 32d757f65c9527e9d03714d3d2e2f82b5f1d05e4
2 changes: 1 addition & 1 deletion csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependabotProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public class DependabotProxy : IDisposable

logger.LogInfo($"Stored Dependabot proxy certificate at {result.CertificatePath}");

result.Certificate = new X509Certificate2(result.CertificatePath);
result.Certificate = X509Certificate2.CreateFromPem(cert);
}

return result;
Expand Down