github · digitalderrick · Aug 14, 2019 · Aug 14, 2019 · Sep 18, 2019 · Oct 7, 2019
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -0,0 +1,83 @@
+# This is a basic workflow to help you get started with Actions
+
+name: CI
+
+env:
+  config: Release
+  githubvsSolution: GitHubVS.sln
+  vsixContainer: ${{ github.workspace }}\GitHub.VisualStudio.vsix
+  ACTIONS_ALLOW_UNSECURE_COMMANDS: true
+
+# Controls when the action will run. Triggers the workflow on push or pull request 
+# events but only for the master branch
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+jobs:
+  # This workflow contains a single job called "build"
+  build:
+    # The type of runner that the job will run on
+    runs-on: windows-latest
+
+    # Steps represent a sequence of tasks that will be executed as part of the job
+    steps:
+    # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
+    - uses: actions/checkout@v1
+      with:
+        submodules: true
+
+    - name: Nerdbank.GitVersioning
+      uses: aarnott/nbgv@v0.3
+      id: nbgv
+
+    - name: Add MSBuild to PATH
+      uses: microsoft/setup-msbuild@v1.0.0
+
+    - uses: nuget/setup-nuget@v1
+      with:
+        nuget-version: '5.x'
+
+    - name: Add VSTest to PATH
+      uses: darenm/Setup-VSTest@v1
+
+    - name: NuGet restore ${{ env.githubvsSolution }}
+      run: nuget restore ${{ env.githubvsSolution }}
+
+    - name: MSBuild ${{ env.githubvsSolution }}
+      run: |
+        msbuild ${{ env.githubvsSolution }} /p:Configuration=${{ env.config }} /p:TargetVsixContainer=${{ env.vsixContainer }} /p:DeployExtension=False /verbosity:minimal
+      env:
+        GitHubVS_ClientId: ${{ secrets.GitHubVS_ClientId }}
+        GitHubVS_ClientSecret: ${{ secrets.GitHubVS_ClientSecret }}
+
+    - name: Sign the VSIX
+      if: github.ref == 'refs/heads/master'
+      run: tools/vsixsigntool/vsixsigntool.exe sign /f certificate.pfx /p '${{ secrets.CERTIFICATE_PASSWORD }}' /sha1 9c5a6d389e1454f2ed9ee9419cdf743689709f9c /fd sha256 /tr http://timestamp.digicert.com /td sha256 ${{ env.vsixContainer }}
+
+    - name: Upload VSIX artifact
+      uses: actions/upload-artifact@v1
+      with:
+        name: GitHubVS-${{ steps.nbgv.outputs.SemVer2 }}
+        path: ${{ env.vsixContainer }}
+
+    # We need to run '**\bin\**\*Tests.dll'
+    - name: Run unit tests
+      shell: bash
+      run: |
+        vstest.console /TestAdapterPath:test /Settings:test/test.runsettings \
+          test/GitHub.Api.UnitTests/bin/${{ env.config }}/net46/GitHub.Api.UnitTests.dll \
+          test/GitHub.App.UnitTests/bin/${{ env.config }}/net46/GitHub.App.UnitTests.dll \
+          test/GitHub.Exports.Reactive.UnitTests/bin/${{ env.config }}/net46/GitHub.Exports.Reactive.UnitTests.dll \
+          test/GitHub.Exports.UnitTests/bin/${{ env.config }}/net46/GitHub.Exports.UnitTests.dll \
+          test/GitHub.Extensions.UnitTests/bin/${{ env.config }}/net46/GitHub.Extensions.UnitTests.dll \
+          test/GitHub.InlineReviews.UnitTests/bin/${{ env.config }}/net46/GitHub.InlineReviews.UnitTests.dll \
+          test/GitHub.Services.Vssdk.UnitTests/bin/${{ env.config }}/net461/GitHub.Services.Vssdk.UnitTests.dll \
+          test/GitHub.StartPage.UnitTests/bin/${{ env.config }}/net46/GitHub.StartPage.UnitTests.dll \
+          test/GitHub.TeamFoundation.UnitTests/bin/${{ env.config }}/net46/GitHub.TeamFoundation.UnitTests.dll \
+          test/GitHub.UI.UnitTests/bin/${{ env.config }}/net46/GitHub.UI.UnitTests.dll \
+          test/GitHub.VisualStudio.UnitTests/bin/${{ env.config }}/net46/GitHub.VisualStudio.UnitTests.dll \
+          test/MetricsTests/MetricsTests/bin/${{ env.config }}/MetricsTests.dll
diff --git a/.gitmodules b/.gitmodules
@@ -10,9 +10,6 @@
 [submodule "submodules/akavache"]
 	path = submodules/akavache
 	url = https://github.com/editor-tools/Akavache
-[submodule "script"]
-	path = script
-	url = git@github.com:github/VisualStudioBuildScripts
 [submodule "submodules/octokit.graphql.net"]
 	path = submodules/octokit.graphql.net
 	url = https://github.com/octokit/octokit.graphql.net
diff --git a/Directory.Build.Props b/Directory.Build.Props
@@ -5,4 +5,10 @@
     <Copyright>Copyright © GitHub, Inc. 2014-2018</Copyright>
     <LangVersion>7.3</LangVersion>
   </PropertyGroup>
+  <ItemGroup>
+    <PackageReference Include="Nerdbank.GitVersioning">
+      <Version>3.0.26</Version>
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
+  </ItemGroup>
 </Project>
diff --git a/GitHubVS.sln b/GitHubVS.sln
@@ -13,7 +13,9 @@ EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Meta", "Meta", "{72036B62-2FA6-4A22-8B33-69F698A18CF1}"
 	ProjectSection(SolutionItems) = preProject
 		.editorconfig = .editorconfig
+		.github\workflows\main.yml = .github\workflows\main.yml
 		README.md = README.md
+		version.json = version.json
 	EndProjectSection
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GitHub.UI", "src\GitHub.UI\GitHub.UI.csproj", "{346384DD-2445-4A28-AF22-B45F3957BD89}"
@@ -31,33 +33,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Submodules", "Submodules",
 		test\UnitTests\Args.cs = test\UnitTests\Args.cs
 	EndProjectSection
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Modules", "Modules", "{8E1F1B4E-AEA2-4AB1-8F73-423A903550A1}"
-	ProjectSection(SolutionItems) = preProject
-		scripts\Modules\BuildUtils.psm1 = scripts\Modules\BuildUtils.psm1
-		scripts\Modules\Debugging.psm1 = scripts\Modules\Debugging.psm1
-		scripts\modules\Versioning.ps1 = scripts\modules\Versioning.ps1
-		scripts\modules\Vsix.ps1 = scripts\modules\Vsix.ps1
-	EndProjectSection
-EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Scripts", "Scripts", "{7B6C5F8D-14B3-443D-B044-0E209AE12BDF}"
-	ProjectSection(SolutionItems) = preProject
-		.gitattributes = .gitattributes
-		.gitignore = .gitignore
-		appveyor.yml = appveyor.yml
-		scripts\build.ps1 = scripts\build.ps1
-		scripts\Bump-Version.ps1 = scripts\Bump-Version.ps1
-		scripts\common.ps1 = scripts\common.ps1
-		scripts\Get-CheckedOutBranch.ps1 = scripts\Get-CheckedOutBranch.ps1
-		scripts\Get-HeadSha1.ps1 = scripts\Get-HeadSha1.ps1
-		scripts\modules.ps1 = scripts\modules.ps1
-		nuget.config = nuget.config
-		scripts\Require-CleanWorkTree.ps1 = scripts\Require-CleanWorkTree.ps1
-		scripts\Run-CodeCoverage.ps1 = scripts\Run-CodeCoverage.ps1
-		scripts\Run-NUnit.ps1 = scripts\Run-NUnit.ps1
-		scripts\Run-Tests.ps1 = scripts\Run-Tests.ps1
-		scripts\Run-XUnit.ps1 = scripts\Run-XUnit.ps1
-	EndProjectSection
-EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Tests", "Tests", "{8A7DA2E7-262B-4581-807A-1C45CE79CDFD}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GitHub.Exports", "src\GitHub.Exports\GitHub.Exports.csproj", "{9AEA02DB-02B5-409C-B0CA-115D05331A6B}"
@@ -519,7 +494,6 @@ Global
 		HideSolutionNode = FALSE
 	EndGlobalSection
 	GlobalSection(NestedProjects) = preSolution
-		{8E1F1B4E-AEA2-4AB1-8F73-423A903550A1} = {7B6C5F8D-14B3-443D-B044-0E209AE12BDF}
 		{1E7F7253-A6AF-43C4-A955-37BEDDA01AC0} = {1E7F7253-A6AF-43C4-A955-37BEDDA01AB8}
 		{08DD4305-7787-4823-A53F-4D0F725A07F3} = {1E7F7253-A6AF-43C4-A955-37BEDDA01AC0}
 		{674B69B8-0780-4D54-AE2B-C15821FA51CB} = {1E7F7253-A6AF-43C4-A955-37BEDDA01AC0}

diff --git a/Key.snk b/Key.snk
diff --git a/README.md b/README.md
@@ -1,25 +1,13 @@
 # GitHub Extension for Visual Studio
 
-## Notices
-
-### If you are having issues with the installer, please read
-
-If you need to upgrade, downgrade, or uninstall the extension, and are having problems doing so, refer to this issue: https://github.com/github/VisualStudio/issues/1394 which details common problems and solutions when using the installer.
-
-### The location of the submodules has changed as of 31-01-2017
-
-If you have an existing clone, make sure to run `git submodule sync` to update your local clone with the new locations for the submodules.
-
 ## About
 
 The GitHub Extension for Visual Studio provides GitHub integration in Visual Studio 2015 and newer.
 Most of the extension UI lives in the Team Explorer pane, which is available from the View menu.
 
-Official builds of this extension are available at [the official website](https://visualstudio.github.com).
+Official builds of this extension are available at the [Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=GitHub.GitHubExtensionforVisualStudio).
 
-[![Build status](https://ci.appveyor.com/api/projects/status/dl8is5iqwt9qf3t7/branch/master?svg=true)](https://ci.appveyor.com/project/github-windows/visualstudio/branch/master)
-[![Build Status](https://github-editor-tools.visualstudio.com/VisualStudio/_apis/build/status/github.VisualStudio?branchName=master)](https://github-editor-tools.visualstudio.com/VisualStudio/_build/latest?definitionId=4&branchName=master)
-[![codecov](https://codecov.io/gh/GitHub/VisualStudio/branch/master/graph/badge.svg)](https://codecov.io/gh/GitHub/VisualStudio)
+![CI](https://github.com/github/visualstudio/workflows/CI/badge.svg)
 
 [![Follow GitHub for Visual Studio](https://img.shields.io/twitter/follow/GitHubVS.svg?style=social "Follow GitHubVS")](https://twitter.com/githubvs?ref_src=twsrc%5Etfw) [![Join the chat at https://gitter.im/github/VisualStudio](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/github/VisualStudio?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 
@@ -28,57 +16,29 @@ Visit the [documentation](https://github.com/github/VisualStudio/tree/master/doc
 
 ## Build requirements
 
-* Visual Studio 2017 (15.7.4)+
-* Visual Studio SDK
-* The built VSIX will work with Visual Studio 2015 or newer
+* Visual Studio 2019
+  * `.NET desktop development` workload
+  * `.NET Core cross platform development` workload
+  * `Visual Studio extension development` workload
 
-## Build
+The built VSIX will work with Visual Studio 2015 or newer
 
-Clone the repository and its submodules in a git GUI client or via the command line:
+## Build
 
-```txt
-git clone https://github.com/github/VisualStudio
-cd VisualStudio
-git submodule init
-git submodule deinit script
-git submodule update
-```
+Clone the repository and its submodules.
 
-Open the `GitHubVS.sln` solution with Visual Studio 2017+.
 To be able to use the GitHub API, you'll need to:
 
-- [Register a new developer application](https://github.com/settings/developers) in your profile.
-- Open [src/GitHub.Api/ApiClientConfiguration_User.cs](src/GitHub.Api/ApiClientConfiguration_User.cs) and fill out the clientId/clientSecret fields for your application. **Note this has recently changed location, so you may need to re-do this**
-
-Build using Visual Studio 2017 or:
-
-```txt
-build.cmd
-```
-
-Install in live (non-Experimental) instances of Visual Studio 2015 and 2017:
-
-```txt
-install.cmd
-```
+- [Register a new developer application](https://github.com/settings/developers) in your profile
+- Create an environment variable `GitHubVS_ClientID` with your `Client ID`
+- Create an environment variable `GitHubVS_ClientSecret` with your `Client Secret`
 
-Note, the script will only install in one instance of Visual Studio 2017 (Enterprise, Professional or Community).
+Execute `build.cmd`
 
-## Build Flavors
+## Visual Studio Build
 
-The following can be executed via `cmd.exe`.
+Build `GitHubVS.sln` using Visual Studio 2019.
 
-To build and install a `Debug` configuration VSIX:
-```txt
-build.cmd Debug
-install.cmd Debug
-```
-
-To build and install a `Release` configuration VSIX:
-```txt
-build.cmd Release
-install.cmd Release
-```
 ## Logs
 Logs can be viewed at the following location:
 
@@ -109,6 +69,6 @@ Visit the [Contributor Guidelines](CONTRIBUTING.md) for details on how to contri
 
 ## Copyright
 
-Copyright 2015 - 2018 GitHub, Inc.
+Copyright 2015 - 2019 GitHub, Inc.
 
 Licensed under the [MIT License](LICENSE.md)
diff --git a/appveyor.yml b/appveyor.yml