0 script diffs are logged as debug instead of info #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors logging behavior for script comparison changes to reduce noise in log output. When generating database schema changes, entities that produce 0 diffs are now logged at Debug level instead of Information level, making the Information-level logs focus only on meaningful changes.
Key Changes:
- Introduced
LogChangeResulthelper method to centralize logging logic - Dynamic log level selection: Information for changes with scripts, Debug for no-change scenarios
- Added proper singular/plural handling for "script" vs "scripts" in log messages
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mike-mones
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how logging is handled when generating script compare changes in the
DatabaseChanges.csfile.The main change is that scripts that produce 0 diffs are logged only in Debug instead of Information level; this removes a lot of noise from the logging output for entities that did not change.