Skip to content

add back in volumeDecimal - #35

Merged
jasonlistep merged 1 commit into
stepfrom
jl.add-volume-decimal
Sep 4, 2024
Merged

add back in volumeDecimal#35
jasonlistep merged 1 commit into
stepfrom
jl.add-volume-decimal

Conversation

@jasonlistep

Copy link
Copy Markdown

Stripe made a breaking change in latest major version (26) renaming volumeDecimal to quantityDecimal (changelog). This PR adds back in volumeDecimal for now for backwards compatibility while we upgrade our Stripe API. We reference this field here in server.

@andreysundukov

Copy link
Copy Markdown

for backwards compatibility while we upgrade our Stripe API.

do we really need this? we can change the fieldname at the same time as we pump version on server side, can't we?

@jasonlistep

jasonlistep commented Sep 4, 2024

Copy link
Copy Markdown
Author

@andreysundukov - so we're unsure of how we actually get Stripe API to upgrade its version (see https://getstep.slack.com/archives/C063CMD01AM/p1725453483821499). Supposedly to upgrade Stripe API version we need to manually do that on Stripe's dashboard (although we appear to never have done this and most of our traffic is on a relatively recent version). In the interim between when we upgrade the SDK version in server and us upgrading the API version, I was thinking there's a possibility that Stripe may still send us volumeDecimal instead of quantityDecimal which we would miss persisting, so as a stopgap we can have both and server can try to persist whichever it receives. Although tbh, it doesn't seem like we are ever persisting fuel at all so this may not end up mattering, but figured it is better to be extra safe.

@jasonlistep
jasonlistep merged commit 6ec4cc9 into step Sep 4, 2024
kukido pushed a commit that referenced this pull request Oct 7, 2024
kukido pushed a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants