[2.0] Allow usage of the public DSN in the client configuration #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
approved these changes
Jun 19, 2018
Collaborator
stayallive
left a comment
There was a problem hiding this comment.
Tested on Sentry.io, LGTM!
Jean85
approved these changes
Jun 19, 2018
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows usage of the public DSN available since Sentry 9 in the client configuration. It's the same change introduced in #615, just ported to the
2.0branch. I have no test machine upgraded yet to that version of the server, so my assumptions about the fact that everything works is based on the unit tests passing. If you can check in a real environment please do it before approving