Skip to content

feat: explicit culprit -> transaction #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mitsuhiko merged 1 commit into from
May 15, 2018
Merged

feat: explicit culprit -> transaction #601

mitsuhiko merged 1 commit into from
May 15, 2018

Conversation

@mitsuhiko
Copy link
Contributor

@mitsuhiko mitsuhiko commented May 14, 2018

This emits transaction culprits as the actual transaction as intended
by the protocol.

@mitsuhiko mitsuhiko requested a review from HazAT May 15, 2018 07:44
@mitsuhiko mitsuhiko merged commit 7bf56a8 into master May 15, 2018
@mitsuhiko mitsuhiko deleted the feature/transaction branch May 15, 2018 07:47
@Jean85 Jean85 mentioned this pull request Aug 3, 2018
Closed
11 tasks
Jean85 added a commit that referenced this pull request Aug 3, 2018
@Jean85
Emit transactions, not culprit (port of #601 to 2.0)
e389a03
@Jean85 Jean85 mentioned this pull request Aug 3, 2018
Merged
@gjuric gjuric mentioned this pull request Aug 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HazAT HazAT HazAT approved these changes

@jan-auer jan-auer jan-auer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mitsuhiko @HazAT @jan-auer