test: add SENTRY_TEST_PATH_PREFIX to crash_marker test database path - #1437
Merged
Merged
Conversation
… path The crash_marker test creates a database directory but was not using SENTRY_TEST_PATH_PREFIX like other tests. This could cause the test to write to an unexpected location on some platforms. This change ensures the database path is properly prefixed with the test path prefix, making it consistent with other tests in the suite. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
JoshuaMoelans
approved these changes
Nov 3, 2025
BernhardMarconato
pushed a commit
to elgatosf/sentry-native
that referenced
this pull request
Apr 21, 2026
… path (getsentry#1437) The crash_marker test creates a database directory but was not using SENTRY_TEST_PATH_PREFIX like other tests. This could cause the test to write to an unexpected location on some platforms. This change ensures the database path is properly prefixed with the test path prefix, making it consistent with other tests in the suite. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the crash_marker test to properly use
SENTRY_TEST_PATH_PREFIXwhen creating the database directory, ensuring consistency with other tests in the suite. This PR fixes a regression introduced by #1404Changes
crash_markertest to includeSENTRY_TEST_PATH_PREFIXprefix in tests/unit/test_basic.c:158-159Background
The crash_marker test was creating a database directory without using the test path prefix that other tests use. This could cause the test to write to an unexpected location on some platforms or testing environments.
🤖 Generated with Claude Code