feat(deno): add google-genai integration#22469
Open
isaacs wants to merge 1 commit into
Open
Conversation
isaacs
requested review from
JPeer264 and
andreiborza
and removed request for
a team
July 21, 2026 20:30
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 21, 2026 20:55
a3bda7b to
af2805c
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-anthropic
branch
from
July 21, 2026 20:55
fcdda49 to
6581776
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 21, 2026 21:31
af2805c to
46512ae
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-anthropic
branch
from
July 21, 2026 21:31
6581776 to
40c51ca
Compare
Comment on lines
+69
to
+72
| Deno.test('google-genai instrumentation: orchestrion @google/genai:generate-content channel produces a nested gen_ai span', async () => { | ||
| resetGlobals(); | ||
| const sink = transactionSink(); | ||
| init({ |
Contributor
There was a problem hiding this comment.
Bug: A module-level installedIntegrations array is not cleared between tests, causing subsequent init() calls to skip setup and leading to test failures.
Severity: MEDIUM
Suggested Fix
The installedIntegrations array should be cleared between tests. This can be done by exporting a reset function from @sentry/core that clears the array and then calling this new function within resetGlobals(). This will ensure each test runs in a clean state.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/deno-integration-tests/suites/orchestrion-google-genai/test.ts#L69-L72
Potential issue: A module-level array, `installedIntegrations`, is not cleared between
tests, even when `resetGlobals()` is called. When a second test in the same file calls
`init()`, the integration's `setupOnce()` function is skipped because the integration
name is already present in the array from the first test's execution. This prevents
diagnostic channel subscriptions from being set up for the second test. Consequently,
the test times out waiting for a transaction that is never created, causing a test
failure.
Also affects:
packages/core/src/integration.ts:10packages/core/src/integration.ts:117~119
Did we get this right? 👍 / 👎 to inform future reviews.
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 21, 2026 21:42
46512ae to
46e8ba9
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-anthropic
branch
from
July 21, 2026 21:43
40c51ca to
3e3e6d2
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 22, 2026 00:51
46e8ba9 to
a2edc7e
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-anthropic
branch
from
July 22, 2026 00:51
3e3e6d2 to
fd6c438
Compare
JPeer264
approved these changes
Jul 22, 2026
nicohrubec
approved these changes
Jul 22, 2026
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 22, 2026 14:42
a2edc7e to
ac2a96d
Compare
isaacs
requested review from
chargome,
msonnb and
mydea
and removed request for
a team
July 22, 2026 14:42
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-anthropic
branch
from
July 22, 2026 14:42
fd6c438 to
126e75d
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-anthropic
branch
from
July 22, 2026 22:02
126e75d to
4c7f4ea
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-google-genai
branch
from
July 22, 2026 22:02
ac2a96d to
dd3e8b8
Compare
Comment on lines
+64
to
+72
| Deno.test('google-genai instrumentation: orchestrion @google/genai:generate-content channel produces a nested gen_ai span', async () => { | ||
| resetGlobals(); | ||
| const sink = transactionSink(); | ||
| init({ | ||
| dsn: 'https://username@domain/123', | ||
| tracesSampleRate: 1, | ||
| beforeSendTransaction: sink.beforeSendTransaction, | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
Bug: Module-level state in installedIntegrations is not reset between tests, causing subsequent calls to init() in the same process to skip the setupOnce() logic for integrations.
Severity: MEDIUM
Suggested Fix
To ensure test isolation, implement a mechanism to reset the module-level state between tests. Export a reset function from the SDK's core integration module that clears the installedIntegrations array. This function should be called in a beforeEach or afterEach hook within the test suite to guarantee each test starts with a clean state.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/deno-integration-tests/suites/orchestrion-google-genai/test.ts#L64-L72
Potential issue: The `installedIntegrations` array is a module-level variable that
persists for the lifetime of a process. When tests run in the same process, the first
test adds the 'Google_GenAI' integration name to this array. The second test calls
`init()` again, but because the integration name is already present in
`installedIntegrations`, the `setupOnce()` function is skipped. This prevents the
diagnostic channel subscription from being established in the second test, causing it to
fail when it asserts the existence of an expected span. This behavior could also occur
in production if `init()` is called multiple times in the same process, causing
instrumentation to silently fail.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.