Skip to content

fix: Read and send unfinished spans - #3533

Merged
jamescrosswell merged 4 commits into
mainfrom
fix/unfinished-span
Aug 14, 2024
Merged

jamescrosswell merged 4 commits into
mainfrom
fix/unfinished-span

Conversation

@bitsandfoxes

@bitsandfoxes bitsandfoxes commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

Fixes getsentry/sentry-unity#1759

With getsentry/relay#1244 spans no longer need to be finished before sent. Without making reading the endTimestamp optional we end up with an error

System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.

@jamescrosswell jamescrosswell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread CHANGELOG.md Outdated
@jamescrosswell
jamescrosswell merged commit b0fc43e into main Aug 14, 2024
@jamescrosswell
jamescrosswell deleted the fix/unfinished-span branch August 14, 2024 21:54
@github-actions

Copy link
Copy Markdown
Contributor
Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Read and send unfinished spans ([#3533](https://github.com/getsentry/sentry-dotnet/pull/3533))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 3d82dfb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants