Regular expressions can now be used for InApp includes/excludes - #3321
Conversation
bitsandfoxes
left a comment
There was a problem hiding this comment.
That is a really nice QOL improvement.
There was a problem hiding this comment.
It's a bit more complicated solution than what I had in mind in my proposal (albeit more flexible too, I guess), but as long as the performance is OK, I'm fine with that. Have you checked the original vs current version in benchmarks manually? Can you please post the results?
@vaind the newer code was actually significantly slower (~40%) so I've tightened it up a bit and now I'm seeing: main branch
inapp-regex branch
Which is cool... now it's way faster and allocates way less memory 🥳 I think most of those gains were simply getting rid of Linq, although I did get rid of another lambda as well. |
vaind
left a comment
There was a problem hiding this comment.
great effort & thanks for the benchmarks
Resolves #3158