Metrics improvements - #3191
Merged
Merged
Metrics improvements#3191
Conversation
This reverts commit 5540494
jamescrosswell
marked this pull request as ready for review
March 5, 2024 08:47
bitsandfoxes
reviewed
Mar 5, 2024
jamescrosswell
commented
Mar 5, 2024
| { | ||
| writer.WritePropertyName(exportKey); | ||
| writer.WriteStartArray(); | ||
| foreach (var metric in value.OrderBy(x => MetricHelper.GetMetricBucketKey(x.MetricType, x.Key, x.Unit, x.Tags))) |
Collaborator
Author
There was a problem hiding this comment.
btw: I'd love to get rid of the OrderBy here. This only exists to ensure the order of things in JSON stays exactly the same, so our Verify tests pass. If I could work out how to have Verify do a Deep object comparison rather than a string compare, we could get rid of the OrderBy here and the ToImmutableSortedDictionary call above.
bitsandfoxes
approved these changes
Mar 6, 2024
bitsandfoxes
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
The IMetricsHub still makes me feel itchy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3175
Span Aggregates
Emitted metrics are now displayed for spans (e.g. here):
Automatic Tags
Tags are set on metrics for Release, Environment and Transaction (where these are present):