it's in package the json you shared

Yes I see that. That's why I added this to my comment:

Ideally we could exclude based on the package name (e.g. libmonosgen bit in the example frame above).

Do we want to do this though? These are our current Excludes:

sentry-dotnet/src/Sentry/SentryOptions.cs

Lines 1296 to 1337 in aae7342

    
           InAppExclude = new() { 
        
                   "System", 
        
                   "Mono", 
        
                   "Sentry", 
        
                   "Microsoft", 
        
                   "MS", // MS.Win32, MS.Internal, etc: Desktop apps 
        
                   "ABI.Microsoft", // MAUI 
        
                   "WinRT", // WinRT, UWP, WinUI 
        
                   "UIKit", // iOS / MacCatalyst 
        
                   "Newtonsoft.Json", 
        
                   "FSharp", 
        
                   "Serilog", 
        
                   "Giraffe", 
        
                   "NLog", 
        
                   "Npgsql", 
        
                   "RabbitMQ", 
        
                   "Hangfire", 
        
                   "IdentityServer4", 
        
                   "AWSSDK", 
        
                   "Polly", 
        
                   "Swashbuckle", 
        
                   "FluentValidation", 
        
                   "Autofac", 
        
                   "Stackexchange.Redis", 
        
                   "Dapper", 
        
                   "RestSharp", 
        
                   "SkiaSharp", 
        
                   "IdentityModel", 
        
                   "SqlitePclRaw", 
        
                   "Xamarin", 
        
                   "Android", // Ex: Android.Runtime.JNINativeWrapper... 
        
                   "Google", 
        
                   "MongoDB", 
        
                   "Remotion.Linq", 
        
                   "AutoMapper", 
        
                   "Nest", 
        
                   "Owin", 
        
                   "MediatR", 
        
                   "ICSharpCode", 
        
                   "Grpc", 
        
                   "ServiceStack" 
        
           };

I'm wary about any of those accidentally matching against package names when they were designed to match module names.

We could probably do it if we were careful about how we designed the matcher. These are the two matchers we have for Module and Function:

sentry-dotnet/src/Sentry/SentryStackFrame.cs

Lines 19 to 20 in 34b5598

    
           private static readonly Lazy<PrefixOrPatternMatcher> LazyModuleMatcher = new(() => new()); 
        
           private static readonly Lazy<DelimitedPrefixOrPatternMatcher> LazyFunctionMatcher = new(() => new());

To match against packages, we'd need a regex that could unpack something like this "/some/path/libmonosgen-2.0.dylib"

	InAppExclude = new() {
	"System",
	"Mono",
	"Sentry",
	"Microsoft",
	"MS", // MS.Win32, MS.Internal, etc: Desktop apps
	"ABI.Microsoft", // MAUI
	"WinRT", // WinRT, UWP, WinUI
	"UIKit", // iOS / MacCatalyst
	"Newtonsoft.Json",
	"FSharp",
	"Serilog",
	"Giraffe",
	"NLog",
	"Npgsql",
	"RabbitMQ",
	"Hangfire",
	"IdentityServer4",
	"AWSSDK",
	"Polly",
	"Swashbuckle",
	"FluentValidation",
	"Autofac",
	"Stackexchange.Redis",
	"Dapper",
	"RestSharp",
	"SkiaSharp",
	"IdentityModel",
	"SqlitePclRaw",
	"Xamarin",
	"Android", // Ex: Android.Runtime.JNINativeWrapper...
	"Google",
	"MongoDB",
	"Remotion.Linq",
	"AutoMapper",
	"Nest",
	"Owin",
	"MediatR",
	"ICSharpCode",
	"Grpc",
	"ServiceStack"
	};

	private static readonly Lazy<PrefixOrPatternMatcher> LazyModuleMatcher = new(() => new());
	private static readonly Lazy<DelimitedPrefixOrPatternMatcher> LazyFunctionMatcher = new(() => new());

Uh oh!

Uh oh!

Mark mono/xamarin/dotnet system symbols as not inApp (iOS) #4194

Description

Activity

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions