feat(integrations): Update developer GitHub integration form #15784
Conversation
- Adds missing permissions. - Adds missing callback url. - Adds option to switch between organiation and personal account when generating the URL. - Fixes dark mode rendering of form fields where text color was illegible when dark mode was enabled.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Cursor Agent can help with this pull request. Just |
runningcode
left a comment
There was a problem hiding this comment.
Great improvement! just one question on the personal vs organization thing.
|
|
||
| const MAX_COMPONENTS_ON_PAGE = 100; | ||
|
|
||
| type AccountType = 'personal' | 'organization'; |
There was a problem hiding this comment.
this looks great. I didn't realize there were two ways of doing this.
When would someone prefer personal vs organization?
There was a problem hiding this comment.
Well in my case I don't have an organisation account so I created the GitHub app on my own personal GitHub account, I didn't have permissions to do this on our main Sentry account.
There was a problem hiding this comment.
Yeah exactly I was thinking a note saying that if you are an individual or testing you should do the personal otherwise use organization.
On second thought maybe that's too much info. It is good as is!
There was a problem hiding this comment.
Funnily enough the Sentry bot said the same thing, I think it's self explanatory tbh.
There was a problem hiding this comment.
Great work on the UX improvement as well 🎉 one small nit: the button in non hovered state on dark mode looks off (maybe invert the behaviour since the hovered state looks more like it should when it's not hovered) 😅
Currently hovered state:
Currently idle state:
DESCRIBE YOUR PR
Updates the https://develop.sentry.dev/integrations/github/ page's GitHub app generation form to:
Also updates the https://develop.sentry.dev/self-hosted/configuration/sso/ page to add multiple callback URLs as required. Doesn't add additional permissions as not needed for that SSO GitHub app.
IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: