Roll Dart SDK from 5dbfbf6487d2 to 28ef48bc86d5 (1 revision) - #186050
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request removes the final modifier from constructor parameters in several result classes within the Zircon system library. The review feedback recommends utilizing super parameters for constructor simplification, adding documentation to public members, and maintaining standard line length limits.
|
autosubmit label was removed for flutter/flutter/186050, because - The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
auto label is removed for flutter/flutter/186050, Failed to enqueue flutter/flutter/186050 with HTTP 400: Pull request Required status check "Check Code Freeze" is queued.. |
|
Autosubmit is wrong. Adding note to #185898 |
https://dart.googlesource.com/sdk.git/+log/5dbfbf6487d2..28ef48bc86d5
2026-05-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.13.0-97.0.dev
Includes manual fixes to address breaking change in the parameter syntax:
finalmodifier is no longer allowed on parameters of functions which are notprimary constructors.
cc @kallentu