Exclude the RawAutocomplete options overlay from the ambient focus traversal tree - #185543
Merged
auto-submit[bot] merged 4 commits intoMay 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the RawAutocomplete widget to exclude its options overlay from the ambient focus traversal tree by wrapping it in an ExcludeFocus widget. This ensures that TAB navigation from the autocomplete field correctly advances to the next focusable sibling instead of entering the options overlay. A regression test has been added to verify this behavior. I have no feedback to provide.
justinmc
approved these changes
Apr 24, 2026
justinmc
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 . I agree with the behavior. Thanks!
Contributor
|
autosubmit label was removed for flutter/flutter/185543, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
This was referenced May 6, 2026
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude the options overlay from the ambient focus traversal tree.
Autocomplete options are navigated by arrow keys (via the widget's own shortcuts) and selected via Enter or tap, so they don't participate in TAB traversal. Without this, TAB from the field would detour into focusable items in the options overlay instead of advancing to the next form field.
Fixes Autocomplete blocks keyboard navigation using TAB