[web] Delete some remaining HTML renderer references - #185487
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes references to the HTML renderer from the Flutter engine and framework, including documentation, the FastMatrix32 utility, and associated tests. The feedback suggests clarifying the useSkia documentation regarding the false case and provides a suggestion to improve the documentation for fontFallbackManager to better explain its purpose.
| /// Using flutter tools option "--web-renderer=canvaskit" would set the value to | ||
| /// true. | ||
| /// | ||
| /// Using flutter tools option "--web-renderer=html" would set the value to false. |
There was a problem hiding this comment.
The removal of the HTML renderer reference leaves the documentation for useSkia incomplete, as it now only describes the true case. It would be beneficial to update the documentation to explain what false represents in the current architecture (e.g., the Skwasm renderer).
There was a problem hiding this comment.
Should this be documented as deprecated or having no effect?
There was a problem hiding this comment.
This flag basically means "use CanvasKit" today, so renaming it to FLUTTER_WEB_USE_CANVASKIT would be my preference but it's a breaking change.
I may rename useSkia to useCanvasKit` though in a future PR.
| // have a font fallback manager and just relies on the browser to fall back | ||
| // properly. | ||
| FontFallbackManager? get fontFallbackManager; | ||
| /// The font fallback manager for this font collection. |
There was a problem hiding this comment.
The documentation for fontFallbackManager is quite sparse. Following the style guide's principle of 'Documentation should be useful', it should explain the purpose of the manager.
| /// The font fallback manager for this font collection. | |
| /// The font fallback manager used to find alternative fonts when a character is missing from the primary font. |
References
- Documentation should be useful: Explain the why and the how. (link)
|
autosubmit label was removed for flutter/flutter/185487, because - The status or check suite Windows framework_tests_misc_leak_tracking has failed. Please fix the issues identified (or deflake) before re-applying this label. |
No description provided.