Skip to content

Bumped Nuke to v9#2865

Merged
dennisdoomen merged 1 commit into
fluentassertions:developfrom
dennisdoomen:bump-nuke-to-v9
Dec 3, 2024
Merged

Bumped Nuke to v9#2865
dennisdoomen merged 1 commit into
fluentassertions:developfrom
dennisdoomen:bump-nuke-to-v9

Conversation

@dennisdoomen

@dennisdoomen dennisdoomen commented Dec 3, 2024

Copy link
Copy Markdown
Member

Fixed some of the breaking changes.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions

github-actions Bot commented Dec 3, 2024 •
edited
Loading

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls

coveralls commented Dec 3, 2024 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 12136625114

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.398%
Totals Coverage Status
Change from base Build 12126138421: 0.0%
Covered Lines: 12373
Relevant Lines: 12562
💛 - Coveralls

jnyrup
jnyrup reviewed Dec 3, 2024
View reviewed changes
Comment thread build.sh Outdated
Comment thread Build/_build.csproj Outdated
Comment thread build.ps1
@ITaluone

ITaluone commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

@dennisdoomen Do you know why UnitTestsNet47 are working here, but not here: #2861 ?

@dennisdoomen

dennisdoomen commented Dec 3, 2024

Copy link
Copy Markdown
Member Author

Do you know why UnitTestsNet47 are working here, but not here: #2861 ?

There was 9.0.2 release last night. Maybe something was broken there?

@ITaluone

ITaluone commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

Hmm.. I checked the commit log.. no commit changed something in the area I expected a change.. I'll try locally...

@dennisdoomen
dennisdoomen merged commit 39371f3 into fluentassertions:develop Dec 3, 2024
@dennisdoomen
dennisdoomen deleted the bump-nuke-to-v9 branch December 3, 2024 13:02
@jnyrup jnyrup added building Building and Infrastructure of Fluent Assertions dependencies Pull requests that update a dependency file labels Dec 27, 2024
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
This was referenced Jul 15, 2026
Closed
Merged
Merged
Merged
Open
Closed
Open
Closed
Closed
Open
Closed
Merged
Closed
Open
Open
Closed
This was referenced Jul 22, 2026
Merged
Open
Open
Closed
Closed
Closed
Open
Closed
Open
Open
Closed
Closed
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup left review comments

Assignees

No one assigned

Labels

building Building and Infrastructure of Fluent Assertions dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dennisdoomen @coveralls @ITaluone @jnyrup