Skip to content

Capitalize true and false in failure messages #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dennisdoomen merged 2 commits into from
Oct 17, 2023
+5 −5
Merged

Capitalize true and false in failure messages #2390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6af9d6
chore: capitalize true and false
BusHero Oct 16, 2023
24bcbb1
docs: update releases.md
BusHero Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Src/FluentAssertions/Primitives/BooleanAssertions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public AndConstraint<TAssertions> BeFalse(string because = "", params object[] b
Execute.Assertion
.ForCondition(Subject == false)
.BecauseOf(because, becauseArgs)
.FailWith("Expected {context:boolean} to be false{reason}, but found {0}.", Subject);
.FailWith("Expected {context:boolean} to be False{reason}, but found {0}.", Subject);

return new AndConstraint<TAssertions>((TAssertions)this);
}
Expand All @@ -71,7 +71,7 @@ public AndConstraint<TAssertions> BeTrue(string because = "", params object[] be
Execute.Assertion
.ForCondition(Subject == true)
.BecauseOf(because, becauseArgs)
.FailWith("Expected {context:boolean} to be true{reason}, but found {0}.", Subject);
.FailWith("Expected {context:boolean} to be True{reason}, but found {0}.", Subject);

return new AndConstraint<TAssertions>((TAssertions)this);
}
Expand Down
4 changes: 2 additions & 2 deletions Tests/FluentAssertions.Specs/Primitives/BooleanAssertionSpecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public void Should_fail_with_descriptive_message_when_asserting_boolean_value_fa
// Assert
action
.Should().Throw<XunitException>()
.WithMessage("Expected boolean to be true because we want to test the failure message, but found False.");
.WithMessage("Expected boolean to be True because we want to test the failure message, but found False.");
}
}

Expand Down Expand Up @@ -78,7 +78,7 @@ public void Should_fail_with_descriptive_message_when_asserting_boolean_value_tr

// Assert
action.Should().Throw<XunitException>()
.WithMessage("Expected boolean to be false because we want to test the failure message, but found True.");
.WithMessage("Expected boolean to be False because we want to test the failure message, but found True.");
}
}

Expand Down
2 changes: 1 addition & 1 deletion docs/_pages/releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ sidebar:
* Fixed that the `because` and `becauseArgs` were not passed down the equivalency tree - [#2318](https://github.com/fluentassertions/fluentassertions/pull/2318)
* `BeEquivalentTo` can again compare a non-generic `IDictionary` with a generic one - [#2358](https://github.com/fluentassertions/fluentassertions/pull/23158)
* Fixed that the `FormattingOptions` were not respected in inner `AssertionScope` - [#2328](https://github.com/fluentassertions/fluentassertions/pull/2328)

* Capitalize `true` and `false` in failure messages - [#2390](https://github.com/fluentassertions/fluentassertions/pull/2390)

### Breaking Changes (for users)
* Moved support for `DataSet`, `DataTable`, `DataRow` and `DataColumn` into a new package `FluentAssertions.DataSet` - [#2267](https://github.com/fluentassertions/fluentassertions/pull/2267)
Expand Down