Ensure explicitly implemented members are discoverable in BeEquivalentTo#2152
Merged
dennisdoomen merged 2 commits intoSep 24, 2023
Merged
Conversation
dennisdoomen
force-pushed
the
Fix/ExplicitInterfaceImpl
branch
2 times, most recently
from
March 26, 2023 19:43
8bb8227 to
be218f7
Compare
7 tasks
dennisdoomen
force-pushed
the
Fix/ExplicitInterfaceImpl
branch
from
April 1, 2023 16:01
be218f7 to
ed44bda
Compare
dennisdoomen
force-pushed
the
Fix/ExplicitInterfaceImpl
branch
from
April 1, 2023 19:01
ed44bda to
d773221
Compare
dennisdoomen
marked this pull request as ready for review
June 6, 2023 19:19
jnyrup
reviewed
Jul 14, 2023
dennisdoomen
force-pushed
the
Fix/ExplicitInterfaceImpl
branch
3 times, most recently
from
August 7, 2023 04:59
35fdb9b to
87cfed7
Compare
dennisdoomen
force-pushed
the
Fix/ExplicitInterfaceImpl
branch
3 times, most recently
from
August 12, 2023 08:15
b391618 to
54d795c
Compare
dennisdoomen
marked this pull request as draft
August 12, 2023 08:17
Pull Request Test Coverage Report for Build 5847999939Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
dennisdoomen
force-pushed
the
Fix/ExplicitInterfaceImpl
branch
4 times, most recently
from
August 12, 2023 11:20
13452cc to
31c4678
Compare
dennisdoomen
marked this pull request as ready for review
August 12, 2023 11:25
jnyrup
reviewed
Aug 13, 2023
dennisdoomen
force-pushed
the
Fix/ExplicitInterfaceImpl
branch
2 times, most recently
from
August 13, 2023 14:06
20c998d to
279656a
Compare
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RespectingDeclaredTypesandRespectingRuntimeTypeswas used. But those options don't affect the subject.WithMappingconstruct also didn't support mapping to properties implemented through explicitly-implemented interfaces.Note I had to extend
MemberVisibilityto optionally include explicitly implemented members. This could be perceived as a breaking change. But it won't affect consumers, so for now, I treat it as non-breaking.Review
Review by commit and with whitespace changes hidden
Fixes #2146
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome