Android - NativeStorage patch applied - #2355
Open
uzzyDC wants to merge 1 commit into
Open
Conversation
local android storage in replaced with IndexedDB using Dexie; maintained compatibility with existing data via automatic migration from Preferences; eliminated the passing of massive JSON strings across the Capacitor bridge; retaind Preferences solely as a migration source; avoided the introducing SQLite or native code at this stage.
Member
|
Wow. Super easy change set! |
Member
|
@copilot resolve the merge conflicts in this pull request |
Member
Is this using Dexie at all? It seems to use indexedDB directly? |
Contributor
Author
Correct, is just indexedDB, no new dependency. |
Contributor
Author
|
Next step is to insert separate records for each bookmark in the db, instead of serialize the entire structure. But it will impact more code. |
Member
See #2357 :) -- I opted to use SQLite for this, rather than indexedDb, because IndexedDB can be dropped by the browser at will, it seems, which wouldn't be nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strongly improve android native app sync performance, especially the first sync of a new profile which could fail for medium-big size of bookmarks.
Mods: