Repository navigation
Conversation
…t bound is past the x dtype range
…he integer dtype ranges
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An ungrouped line on an in-memory frame with a null or NaN in x returned 500 for every request. The line now skips those rows, as histograms do.
check_line_xaccepts nulls at the start and NaN at the end of a sorted x (Polars sort order), and warns once with their counts. The check stays one collect.sort(nulls_last=True), which keeps a sorted flag), still raises "not sorted".Integer bounds past the dtype range:
UInt64x started the window in the null rows, and a pan above 255 onUInt8emptied the line, also on data without nulls. A zoomed histogram or 2D histogram on such a column, and a range selection on it, returned nothing._typed_range_boundsnow clamps a numeric integer bound to the dtype range, and a range wholly outside it is empty. The line windows, the histogram grids and the selection predicates all use it.Measured on a resident 50M-row frame (4 threads, Float64, Float32, Int64 and Datetime x): the data check and the warm requests take the same time as before within noise, the peak memory stays at 0.1 MB (the slice is zero-copy), and a frame with a null prefix and a NaN suffix costs the same as a clean one.
Tests: minmax, lttb and fpcs with a null prefix and a NaN suffix equal the clean frame; scan equals in-memory; a multi-chunk null prefix; one warning per source and column; the sorted-flag cases; line zooms past the dtype range; histogram zooms and range selections past the dtype range equal the
Int64andFloat64results; non-numeric bounds.Closes #25