[Deploy preview] Skip pseudo-libraries like [vdso] during symbolication#6099
Draft
canova wants to merge 1 commit into
Draft
[Deploy preview] Skip pseudo-libraries like [vdso] during symbolication#6099canova wants to merge 1 commit into
canova wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6099 +/- ##
========================================
Coverage 83.34% 83.34%
========================================
Files 338 338
Lines 35868 35871 +3
Branches 9944 10050 +106
========================================
+ Hits 29895 29898 +3
Misses 5545 5545
Partials 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pseudo-modules such as [vdso], [vsyscall], [heap], [stack] and
[anon:...] are kernel- or allocator-provided mappings that have no
symbol files, so requesting symbols for them is always pointless.
Worse, it is now actively harmful because the Mozilla symbolication
server (Eliot) rejects the entire batched /symbolicate/v5 request with
an HTTP 400 ("job N has invalid modules: module index 0 has an invalid
debug_filename") when any job's module name contains brackets. Because
we batch up to 10 libraries into a single request, that 400 has no
`results` field and our response validation throws for the whole chunk,
so every other library in it (most importantly libxul) fails to
symbolicate too. The net effect is a profile with no symbols at all,
even though the symbols are available on the server.
This was previously harmless, Eliot (I think) used to tolerate [vdso],
returning found_modules: false for that job while symbolicating the
rest, which only produced a per-library warning in the console.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pseudo-modules such as [vdso], [vsyscall], [heap], [stack] and [anon:...] are kernel- or allocator-provided mappings that have no symbol files, so requesting symbols for them is always pointless.
Worse, it is now actively harmful because the Mozilla symbolication server (Eliot) rejects the entire batched /symbolicate/v5 request with an HTTP 400 ("job N has invalid modules: module index 0 has an invalid debug_filename") when any job's module name contains brackets. Because we batch up to 10 libraries into a single request, that 400 has no
resultsfield and our response validation throws for the whole chunk, so every other library in it (most importantly libxul) fails to symbolicate too. The net effect is a profile with no symbols at all, even though the symbols are available on the server.This was previously harmless, Eliot (I think) used to tolerate [vdso], returning found_modules: false for that job while symbolicating the rest, which only produced a per-library warning in the console.