Update isLocalURL to include LAN addresses, .local domains, and hostn…#5973
Merged
Conversation
38f05a1 to
c5cad4d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5973 +/- ##
==========================================
+ Coverage 83.77% 83.78% +0.01%
==========================================
Files 329 329
Lines 34559 34587 +28
Branches 9574 9698 +124
==========================================
+ Hits 28952 28979 +27
- Misses 5178 5179 +1
Partials 429 429 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
reviewed
Apr 30, 2026
canova
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR, adding some comments below.
7dcfd1c to
ee13e17
Compare
Contributor
Author
|
before: 
after: 
|
Contributor
Author
|
can this pr be merged? |
Contributor
|
Hey @cathaysia, you need to re-request review when you've done working on the feedback. I'll do that for you now :) |
Contributor
Author
|
thanks |
canova
requested changes
May 27, 2026
Comment on lines
+24
to
+30
| /^127\./.test(hostname) || // Loopback 127.0.0.0/8 | ||
| /^10\./.test(hostname) || // Private 10.0.0.0/8 | ||
| /^172\.(1[6-9]|2[0-9]|3[0-1])\./.test(hostname) || // Private 172.16.0.0/12 | ||
| /^192\.168\./.test(hostname) || // Private 192.168.0.0/16 | ||
| /^100\.(6[4-9]|[7-9][0-9]|1[0-1][0-9]|12[0-7])\./.test(hostname) || // CGNAT 100.64.0.0/10 | ||
| /^169\.254\./.test(hostname) || // Link-local 169.254.0.0/16 | ||
| /^198\.(1[8-9])\./.test(hostname) // Benchmark 198.18.0.0/15 |
Member
There was a problem hiding this comment.
These match hostnames like:
192.168.1.1.foo.com
URL.hostname will happily return these host names. Please make sure that the host names are actually ipv4 addresses.
Contributor
Author
There was a problem hiding this comment.
I updated the regex, could you please check it again?
a76c6c5 to
1ae49e4
Compare
Merged
canova
added a commit
that referenced
this pull request
Jun 16, 2026
Changes: [Nazım Can Altınova] Fix call node context menu being hidden behind source view bottom box (#6045) [Nazım Can Altınova] Pass `--use-env-proxy` only when the node version is >= 24 (#6064) [fatadel] Upgrade @firefox-devtools/react-contextmenu to 5.2.4 (#6066) [Markus Stange] Switch profiler-edit from minimist to commander (#6065) [Markus Stange] Support reading profiles from JsonSlabs files (#6037) [Florian Quèze] Don't fail profile processing when a marker's stack field is not a backtrace (#6069) [fatadel] Replace the footer-links overlay with a settings menu (#6042) [fatadel] Upgrade @types/node to match Node 24 (#6070) [fatadel] Remove unused undici-types package (#6074) [cathaysia] Update isLocalURL to include LAN addresses, .local domains, and hostn… (#5973) [Markus Stange] Fix from-url with binary profiles (#6072) [fatadel] Upgrade to React 19 (#6067) [Markus Stange] Add an insertStackLabels helper. (#6076) [fatadel] Drive counter tooltips from a tooltipRows schema (#6023) [fatadel] Add TrackPower--tooltip-average-power-microwatt (#6080) [Markus Stange] Downgrade to React 19.1 to fix unusable dev build performance. (#6082) [Nazım Can Altınova] Add source map symbolication and source view support (#6018) [spokodev] fix(FilterNavigatorBar): clip overflow so many breadcrumbs do not expand the parent (#6085) [Markus Stange] Move paddings inside the tree header cells. (#6002) [Markus Stange] Add an --insert-label-frames argument to the profiler-edit tool (#5966) [Markus Stange] Stop printing "error: too many arguments" during tests. (#6088) [Markus Stange] More additions to profiler-edit, for sp3 profiles (#6009) [Nazım Can Altınova] Do not rely on localized texts in the settings menu tests (#6101) And special thanks to our localizers: be: Andrei Mukamolau de: Ger de: Michael Köhler de: Ralf Duehnfahr el: Jim Spentzos en-CA: chutten en-GB: Ian Neal es-CL: ravmn fr: Théo Chevalier fr: wy fur: Fabio Tomat fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Mark Heijl ru: Valery Ledovskoy sr: Марко Костић (Marko Kostić) sv-SE: Andreas Pettersson tr: Grk tr: Selim Şumlu zh-CN: Olvcpr423 zh-TW: Pin-guang Chen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat non-public addresses—such as loopback addresses, LAN addresses, and CGNAT addresses—as local addresses; this allows for direct access to computers within the local network, Tailscale and etc..