Make network markers in the network panel sticky on click#5884
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5884 +/- ##
==========================================
+ Coverage 85.44% 85.46% +0.01%
==========================================
Files 321 321
Lines 32050 32079 +29
Branches 8836 8841 +5
==========================================
+ Hits 27385 27415 +30
+ Misses 4233 4232 -1
Partials 432 432 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f9b12db to
1cc967a
Compare
canova
left a comment
There was a problem hiding this comment.
Thanks!
It looks like when the network marker is sticky, we still see another tooltip on top of it, which obstructs the other one. Is it possible to make the other tooltips not visible when there is already a sticky tooltip?
See an example:
I see that we already do this in the marker chart/table. So it might be good to have the same behavior
Show filter button only in sticky (clicked) tooltips
I'm a bit confused by this one. Can we make it visible all the time? This is the current behavior of marker chart too.
1cc967a to
df48629
Compare
|
Hey @canova, Thanks for the valuable feedback! I agree with all the points you've raised. I've now incorporated your feedback - could you pls have another look? |
canova
left a comment
There was a problem hiding this comment.
Thanks! Looks good but I have one more thing I would like to see fixed.
When I right click on a marker while I have a sticky tooltip, it shows both of them and they overlap with each other too:
Can we hide the tooltip when there is context menu?
When clicking a marker in the Network panel, its tooltip is now persisted, matching the Marker Chart behavior. This enables interaction with tooltip content like copying text or clicking the filter button. The existing behavior of displaying the tooltip on hover is kept as well, but hover tooltips are suppressed while a sticky tooltip is active, to avoid obstruction. - Add click coordinate tracking to NetworkChartRow state for sticky tooltip positioning - Show filter button in both hover and sticky tooltips - Suppress hover tooltips on other rows while a sticky tooltip is active - Toggle selection off when re-clicking the same row - Dismiss sticky tooltip on Escape key - Add new tests covering the sticky tooltip related behavior
df48629 to
3ddf9d9
Compare
|
Thanks for the feedback @canova! I have now addressed your points :) |
Changes: [Markus Stange] Start using const enum (#5879) [Markus Stange] Some performance improvements (#5878) [Nazım Can Altınova] Add startLine, startColumn, sourceMapURL and rename uuid to id in source table (#5882) [Markus Stange] Reduce repetition in profile compacting code (#5885) [Markus Stange] Some more activity graph drawing perf improvements (#5886) [fatadel] Make network markers in the network panel sticky on click (#5884) [Markus Stange] Improve SampleGraph and HeightGraph performance (#5897) [Nazım Can Altınova] 🔃 Sync: l10n -> main (March 20, 2026) (#5899) And special thanks to our localizers: be: Andrei Mukamolau el: Jim Spentzos en-GB: Paul es-CL: ravmn ia: Melo46 sv-SE: Andreas Pettersson tr: Nazım Can Altınova
Closes #5751.
When clicking a marker in the Network panel, its tooltip is now persisted, matching the Marker Chart behavior.
This enables interaction with tooltip content like copying text or clicking the filter button.
The existing behavior of displaying the tooltip on hover is kept as well, but hover tooltips are suppressed while a sticky tooltip is active, to avoid obstruction.
Before / After