Skip to content

Make extractGeckoLogs() not fake the D/ log level if the log module already contains it#5811

Merged
canova merged 2 commits into
firefox-devtools:mainfrom
valenting:dedupe-log-level
Feb 5, 2026
Merged

Make extractGeckoLogs() not fake the D/ log level if the log module already contains it#5811
canova merged 2 commits into
firefox-devtools:mainfrom
valenting:dedupe-log-level

Conversation

@valenting

Copy link
Copy Markdown
Contributor

Since 1995503 - Include the logging level in MOZ_LOG profiler markers (take 2) landed the module string in the profile now contains the log level.
Without this patch we always fake the log module to D/ meaning the log modules in extractGeckoLogs will be something like D/D/nsJar.

This change makes it so we don't add the D/ prefix if the log module already contains a / character.

@codecov

codecov Bot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.56%. Comparing base (5445a18) to head (355b3b6).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5811   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         320      320           
  Lines       31419    31421    +2     
  Branches     8649     8648    -1     
=======================================
+ Hits        26884    26886    +2     
  Misses       4104     4104           
  Partials      431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@canova canova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for the fix!

@canova canova enabled auto-merge (squash) February 5, 2026 13:00
@canova canova merged commit 6599bc2 into firefox-devtools:main Feb 5, 2026
19 checks passed
@canova canova mentioned this pull request Feb 11, 2026
canova added a commit that referenced this pull request Feb 11, 2026
Changes:
[Valentin Gosu] Make extractGeckoLogs() not fake the D/ log level if the
log module already contains it (#5811)
[Markus Stange] Improve how we pick the "default" native symbol for the
assembly view when double-clicking a call node with multiple native
symbols (#5788)
[fatadel] Use base 10 when calculating memory (#5810)
[Markus Stange] Remove unused function
getEmptySamplesTableWithResponsiveness (#5825)
[arai-a] Make the dark-mode selected timeline background more similar to
non-selected color/contrast, and use slightly brigher colors for the
timeline and category (#5823)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (February 11, 2026) (#5827)

And special thanks to our localizers:
de: Ger
de: Michael Köhler
el: Jim Spentzos
en-CA: chutten
en-CA: Saurabh
en-GB: Ian Neal
es-CL: ravmn
ia: Martijn Dekker
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Mark Heijl
pt-BR: Marcelo Ghelman
ru: Valery Ledovskoy
sv-SE: Andreas Pettersson
tr: Nazım Can Altınova
tr: Selim Şumlu
zh-CN: Olvcpr423
zh-CN: wxie
zh-TW: Pin-guang Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants