Deploying January 28, 2019#1694
Merged
Merged
Conversation
julienw
commented
Jan 28, 2019
Contributor
- Add a category breakdown to the sidebar
- LogMarker support
- minor GC markers tooltips changes
- use category colors in flame graph
- accessibility fixes in MenuButtons
- close panels with the escape key
- cleaner URL for default parameters
- Import 2 profiles in one view
- Error boundaries
- better handling of tracing markers without an end in the profile
Text-only implementation of #1080
Two fields in the GC markers have before and after parts. Update the labels for these fields to include "(pre - post)" making the meaning clearer.
In this patch we implement the logic to import 2 profiles into the Profile Viewer. First step for #470.
…lopment (#1621) Co-Authored-By: jankeromnes <jan.keromnes@typefox.io>
…e key (#1622) This patch also adds more and better tests for the component ButtonWithPanel.
…re applicaton (Merge PR #1660)
We had a WebWorker named zeeWorker in global scope before and because of that jest was hanging before with a following message: "Jest has detected the following 1 open handle potentially keeping Jest from exiting."
Previously, it was opening the panel immediately after the URL shortening happens. And it was generally before profile upload event. That was causing some confusion for users since they were closing the tab too early thinking that the upload process is complete after the URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.