Remove the left margin on all graphs#1181
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1181 +/- ##
==========================================
- Coverage 75.74% 75.74% -0.01%
==========================================
Files 144 144
Lines 9319 9318 -1
Branches 2253 2254 +1
==========================================
- Hits 7059 7058 -1
Misses 2013 2013
Partials 247 247
Continue to review full report at Codecov.
|
mstange
approved these changes
Aug 7, 2018
Contributor
|
The flame graph also has a margin, we should remove that one too, shouldn't we? |
5cdeef9 to
0afcf48
Compare
Member
Author
|
@brisad ah yeah, I missed that, I added that on with this commit. |
0afcf48 to
d113725
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the left margin on the stack and marker charts. The original idea was to have the charts aligned with the graph above, but that is no longer a concern. I was doing some performance audits on that area, and found the thread name to be paint flashing, so it seemed like a good idea to go ahead and remove it since that is what we've already been discussing.
Before changes:
After changes:
