Deploy latest changes#1160
Merged
Merged
Conversation
julienw
commented
Jul 26, 2018
Contributor
- handle PageUp/PageDown/Home/End keys in the call tree
- Enable the sidebar for the call tree and the flame chart
…stcase + add an assertion that the virtualization behavior isn't triggered
… the testcase + add an assertion that the virtualization behavior isn't triggered
This upgrade needed to happen due to a runtime error being generated by the ModuleConcatenationPlugin where it would attempt to reassign a const variable. The largest change for this upgrade is that the Uglify plugin is no longer encouraged, and it is preconfigured under the minimize option. Unfortunately this meant that we lost the yarn start-prod-readable command, as the configuration ignored attempts at not mangling variable names. Start time before upgrade: 7701ms Start time after upgrade: 8112ms Bundle size before upgrade: 686 KiB Bundle size after upgrade: 675 KiB
Codecov Report
@@ Coverage Diff @@
## production #1160 +/- ##
=============================================
+ Coverage 73.28% 73.7% +0.41%
=============================================
Files 140 140
Lines 8633 8659 +26
Branches 2026 2038 +12
=============================================
+ Hits 6327 6382 +55
+ Misses 2036 2016 -20
+ Partials 270 261 -9
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.