feat(fcm): enable direct_boot_ok as bool in Android config#638
Merged
lahirumaramba merged 2 commits intoOct 21, 2024
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
akankshaJaiswal8
marked this pull request as ready for review
August 6, 2024 22:32
akankshaJaiswal8
force-pushed
the
enable_direct_boot_mode
branch
from
August 6, 2024 23:46
347d894 to
3c85b5c
Compare
lahirumaramba
requested changes
Aug 26, 2024
lahirumaramba
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution! Looks pretty good!
Let's remove the changes in .idea from this PR
Member
There was a problem hiding this comment.
Let's remove the .idea directory from this PR
Member
There was a problem hiding this comment.
Let's remove the .idea directory and all the files under it from this PR
lahirumaramba
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
Testing
go test -test.short firebase.google.com/go/...
? firebase.google.com/go/v4/errorutils [no test files]
? firebase.google.com/go/v4/integration/internal [no test files]
? firebase.google.com/go/v4/snippets [no test files]
ok firebase.google.com/go/v4 3.946s
ok firebase.google.com/go/v4/appcheck 1.608s
ok firebase.google.com/go/v4/auth 4.664s
ok firebase.google.com/go/v4/auth/hash 3.035s
ok firebase.google.com/go/v4/db 2.847s
ok firebase.google.com/go/v4/iid 2.115s
ok firebase.google.com/go/v4/integration/auth 4.185s
ok firebase.google.com/go/v4/integration/db 4.624s
ok firebase.google.com/go/v4/integration/firestore 5.664s
ok firebase.google.com/go/v4/integration/iid 5.171s
ok firebase.google.com/go/v4/integration/messaging 6.141s
ok firebase.google.com/go/v4/integration/storage 6.411s
ok firebase.google.com/go/v4/internal 7.386s
ok firebase.google.com/go/v4/messaging 6.563s
ok firebase.google.com/go/v4/storage 7.937s
API Changes