[SQL] Remove MapIndex operators after tables with primary keys#5887
Open
mihaibudiu wants to merge 1 commit intomainfrom
Open
[SQL] Remove MapIndex operators after tables with primary keys#5887mihaibudiu wants to merge 1 commit intomainfrom
mihaibudiu wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mythical-fred
approved these changes
Mar 20, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. Clean decomposition of the old monolith into a focused package. The structural circuit assertions in IncrementalRegression2Tests are exactly the right way to test this kind of optimization.
| super.postorder(closure); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: missing newline at end of file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial intent of this PR was to allow sharing of indexes between the table integral and any other joins that may use the table. This does not seem to work actually, since DBSP cannot figure out from the graph supplied that the integrals are shareable.
But this optimization is still useful, since it will allow multiple joins of an input table that join on the primary key to share the same index.
I have refactored the previous code to share indexes by moving all classes to a new package and moving many inner classes around. That's why the PR looks bigger.