[SQL] Better validation to reject ROWS window queries#5876
Merged
mihaibudiu merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
lalithsuresh
approved these changes
Mar 19, 2026
mythical-fred
approved these changes
Mar 20, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. Fixes the ROWS validation gap with a proper UnimplementedException and a regression test. The fix to object (instead of node) is also correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test with a program that should have been rejected by the compiler, but wasn't.
I had to edit two qa programs for this to pass as well.
It is conceivable that (at least some forms) of ROWS could be supported, but some DBSP help is needed.