Conversation
mythical-fred
approved these changes
Mar 19, 2026
| @@ -593,6 +593,8 @@ impl InputQueue<(), Box<dyn InputBuffer>> { | |||
| /// | |||
| /// Use [`TransportInputEndpoint::open`] to obtain an [`InputReader`]. | |||
There was a problem hiding this comment.
The as_any method requires 14 implementors to each copy the same one-liner body. A helper supertrait with a blanket default (e.g. AsAnyArc) or a derive macro could eliminate that boilerplate. Not a blocker, just worth noting.
mihaibudiu
approved these changes
Mar 19, 2026
| } | ||
|
|
||
| impl InputReader for DeltaTableInputReader { | ||
| fn as_any(self: Arc<Self>) -> Arc<dyn std::any::Any + Send + Sync> { |
Contributor
There was a problem hiding this comment.
couldn't this be a default function in the InputReader trait?
gz
approved these changes
Mar 24, 2026
Fix several issues in the management of HTTP input connectors: 1. We used to create one connector per actix runtime thread for each connector config, e.g., with 8 threads we'd eventually have 8 connectors after several HTTP requests. This could be confusing to the user. Instead, we now create one connector, but cache a reference to it in a thread-local variable for fast lookup. 2. After a stop/resume cycle, we'd create a fresh set of connectors, while the old connectors were still there as well. The number of connectors could grow indefinitely with the number of restarts. We fix this by making connector names stabe across restarts. 3. We drop all HTTP connectors when the pipeline was modified and required bootstrapping; we would then create fresh HTTP connectors after restart. This is ok, except that we lost connector statistics (number of ingested records, errors, etc.) We now preserve HTTP connectors as long as the associated table is not affected by bootstrapping. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
Auto-generated HTTP connector names did not follow the naming scheme expected by the API (`relation_name.connector_name`). This broke connector status reporting. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
The test doesn't need to call wait_for_completion to make sure an HTTP ingest has completed. We now use completion token for this; in fact input_json waits for a completion token when called with `wait=true` (the default). Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
We used to drop the token returned by push_to_pipeline on the floor. Instead, we now return it to the user so they can wait for the token asynchronously. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
de31347 to
4aa9536
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages.