Add Windows fda install script, update docs#5856
Merged
Karakatiza666 merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
gz
approved these changes
Mar 18, 2026
| # Feldera fda CLI installer for Windows | ||
| # Usage: | ||
| # irm https://feldera.com/install-fda.ps1 | iex | ||
| # $env:FDA_VERSION="v0.247.0"; irm https://feldera.com/install-fda.ps1 | iex |
Contributor
There was a problem hiding this comment.
Suggested change
| # $env:FDA_VERSION="v0.247.0"; irm https://feldera.com/install-fda.ps1 | iex | |
| # $env:FDA_VERSION="v0.270.0"; irm https://feldera.com/install-fda.ps1 | iex |
mythical-fred
approved these changes
Mar 18, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. One minor nit on the install script:
| $BinDir = "$FelderaInstall\bin" | ||
|
|
||
| # Only x86_64 is supported (arm64 Windows runner lacks Rust/MSVC in CI) | ||
| $Arch = (Get-CimInstance Win32_Processor).AddressWidth |
There was a problem hiding this comment.
Nit: AddressWidth returns 32 or 64 based on OS bitness, not CPU architecture. It correctly blocks 32-bit Windows, but arm64 Windows will also pass this check (both report 64). Since only x86_64-pc-windows-msvc is shipped right now that is fine — just worth a comment: # Note: detects 32-bit OS; arm64 will pass.
d641c95 to
285ca11
Compare
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
285ca11 to
185aaad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: manual testing of install script and shell completion
Screencast.from.2026-03-18.16-18-20.webm