Conversation
Fixes: #5799 Follows the same scheme as the kubernetes secret resolver. To resolve an env var successfully, the string must start with: `${env:` and end with `}`. The env var name then has to start from a valid alphabet, or underscore. The name then may contain numbers. Example: `"table": "${env:TABLE_NAME}"` Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
Signed-off-by: feldera-bot <feldera-bot@feldera.com>
Contributor
mythical-fred
approved these changes
Mar 16, 2026
| Ok(value) => Ok(value), | ||
| Err(env::VarError::NotPresent) | Err(env::VarError::NotUnicode(_)) => { | ||
| Err(SecretRefResolutionError::EnvVarNotSet { | ||
| env_ref: secret_ref, |
There was a problem hiding this comment.
When env::var returns VarError::NotUnicode, the variable is set — it just contains non-UTF-8 bytes. Mapping it to EnvVarNotSet produces a misleading error: the user will check env | grep VAR, see it set, and wonder why Feldera says otherwise.
Consider a separate error variant, or at minimum tweak the message to "is not set or contains non-UTF-8 bytes".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Manual Test Plan
Manually tested by creating a pipeline with env vars in connector config and setting env vars via the pipeline config.
Fixes: #5799
Checklist