[adapters] NATS: Reduce probe API calls and default inactivity timeout to 60s#5828
Merged
blp merged 3 commits intofeldera:mainfrom Mar 16, 2026
Merged
Conversation
f31d3b5 to
36576ca
Compare
mythical-fred
approved these changes
Mar 15, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. is safe here — already fetches stream state, so this is a pure optimization (one fewer roundtrip). Default timeout 10→60 is sensible and documented in the changelog.
fetch_stream_state called get_stream and then stream.info, causing two STREAM.INFO requests per probe. Use get_stream's cached info to avoid duplicate JetStream API calls during health checks and retries. Signed-off-by: kfollesdal <kristoffer.follesdal@eviny.no>
Raise the default inactivity timeout from 10 to 60 seconds to reduce premature health-check retries on quiet streams. Signed-off-by: kfollesdal <kristoffer.follesdal@eviny.no>
Signed-off-by: kfollesdal <kristoffer.follesdal@eviny.no>
36576ca to
5f0ffd4
Compare
Member
|
Thank you! |
blp
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Manual Test Plan
Just run test. No manual test.
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes