pipeline-manager: fix starting pipeline while clearing storage#5812
Merged
pipeline-manager: fix starting pipeline while clearing storage#5812
Conversation
mythical-fred
suggested changes
Mar 12, 2026
gz
approved these changes
Mar 12, 2026
mythical-fred
approved these changes
Mar 12, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Changelog added, and I was wrong about the { .. } pattern — it compiles fine on unit variants. LGTM.
72975a6 to
4ea4663
Compare
Before it was possible to (early) start a pipeline while storage was still clearing, and to clear storage while still awaiting the transition of the resources status during early start. Only once the resources status transitioned, was it no longer possible for storage status to change. Changes: - No longer allow a pipeline to be (early) started when the storage is still clearing, returning an error instead. - No longer allow storage to be cleared during early start, returning an error instead. - Always allow any of the other resources statuses to transition to `Stopping`, even if storage status does not match expectation. The same for transitioning from `Stopping` to `Stopped`. This is a fail-safe for if storage status ends up in an expected status due to an internal error. Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
4ea4663 to
8a60a79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before it was possible to (early) start a pipeline while storage was still clearing, and to clear storage while still awaiting the transition of the resources status during early start. Only once the resources status transitioned, was it no longer possible for storage status to change.
Changes:
Stopping, even if storage status does not match expectation. The same for transitioning fromStoppingtoStopped. This is a fail-safe for if storage status ends up in an expected status due to an internal error.PR information