python: waiting arguments for pipeline.clear_storage()#5808
Merged
Conversation
abhizer
reviewed
Mar 12, 2026
abhizer
approved these changes
Mar 12, 2026
gz
approved these changes
Mar 12, 2026
mythical-fred
approved these changes
Mar 12, 2026
Before, it was only possible to clear storage in a blocking way using the `pipeline.clear_storage()` function. Now, it's possible to specify whether to wait, and as well how long and at which frequency to check if storage has been cleared. The default behavior of calling the function without arguments remains, which is to wait indefinitely. Tests are added accordingly, including one future test that is skipped for now but will be made to pass in a follow-up PR. Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
e08b308 to
6c56260
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, it was only possible to clear storage in a blocking way using the
pipeline.clear_storage()function. Now, it's possible to specify whether to wait, and as well how long and at which frequency to check if storage has been cleared. The default behavior of calling the function without arguments remains, which is to wait indefinitely.Tests are added accordingly, including one future test that is skipped for now but will be made to pass in a follow-up PR.
PR information
FelderaClient.clear_storage(...)has its optional named argumenttimeout_sposition changed to be afterwait. Given it's an optional named argument (not positional) and it's theFelderaClient(notPipeline) and thus shouldn't be used directly, this is an acceptable change.