[web-console] Update web console vite config with dedupe#5797
[web-console] Update web console vite config with dedupe#5797anandbraman merged 1 commit intomainfrom
Conversation
4f6b920 to
7bd74cb
Compare
|
@anandbraman Why is this necessary? You can leverage the NPM Workspace feature to install a dependency only in the root, and it will be resolved by Bun even for child projects. |
|
@Karakatiza666 the support-bundle-triage package is not a child of feldera js-packages. CI runs into build issues in resolving the dependencies of the package, particularly the triage-types and profiler-lib dependencies. Adding this config resolves the issue. Now, when the support bundle triage package is installed, the dependencies are resolved based on the workspace |
Karakatiza666
left a comment
There was a problem hiding this comment.
This is a decent solution; I don't think it fixes the issue for tools like svelte-check that don't use Vite's module resolution - ideally the conflicting libraries would be installed as peerDependencies in support-bundle-triage.
What I previously mentioned about NPM workspaces indeed can't solve this problem by itself.
Describe Manual Test Plan
Added dedupe to the web-console vite config to ensure that when the support bundle package is installed that common dependencies are resolved from the feldera workspace root
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes