[SQL] Use stable sorting for the circuit graph -- will produce fewer …#5796
Merged
mihaibudiu merged 1 commit intomainfrom Mar 17, 2026
Merged
[SQL] Use stable sorting for the circuit graph -- will produce fewer …#5796mihaibudiu merged 1 commit intomainfrom
mihaibudiu merged 1 commit intomainfrom
Conversation
…changes when program is edited Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mythical-fred
approved these changes
Mar 11, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. Kahn's over DFS-reversePost is the right call -- stable output means fewer spurious diffs when re-compiling unchanged programs. The addNode guarantee (every node gets an empty edge list on insertion) means the this.edges.get(u) call in the main loop is safe. The early-return optimization in LinearPostprocessRetainKeys is a nice bonus.
ryzhyk
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…changes when program is edited. Today the graph is resorted in some circumstances, and the sort is not stable. This may causes unnecessary changes in the output Rust program when the SQL program is edited, especially with regards to global constants that are shared between multiple operators. A stable sort should make these changes less likely.
Fixes #5752
Describe Manual Test Plan
Ran all Java tests manually