Conversation
mythical-fred
suggested changes
Mar 10, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
One concrete bug (serde(default) missing) and a pre-existing variable swap worth fixing while you're in this code.
bc672cb to
38225c3
Compare
mythical-fred
approved these changes
Mar 10, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Both fixes look good — #[serde(default)] is on read_bucket and the retention_min_count/retention_min_age swap is corrected. LGTM.
Adds the `read_bucket` config to the sync config that is used as a one time, read only source for the pipeline to start from. This lets one pipeline start from the state of another pipeline, which saves the time required to backfill the new pipeline. Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
Configures python docs to automatically use the python package version. + clippy fixes Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
38225c3 to
3f4ee71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Manual Test Plan
Tested locally using the sync tests and minio.
Checklist