[SQL] Support OVER windows for DECIMAL and short INTERVAL types#5787
Merged
mihaibudiu merged 2 commits intomainfrom Mar 10, 2026
Merged
[SQL] Support OVER windows for DECIMAL and short INTERVAL types#5787mihaibudiu merged 2 commits intomainfrom
mihaibudiu merged 2 commits intomainfrom
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: feldera-bot <feldera-bot@feldera.com>
Contributor
|
@mihaibudiu doesn't this need documentation updates? |
lalithsuresh
approved these changes
Mar 10, 2026
mythical-fred
approved these changes
Mar 10, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. The decimal max-literal fix is correct (dot was placed after scale digits instead of after precision - scale digits), the new opcodes are wired through all required dispatch points including monotone transfer, and the tests validate real outputs against Postgres. Clean.
Contributor
Author
Technically we already support this, so there is no new stuff to talk about in the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5766
This advances the calcite version, since it depends on a bug which I fixed in Calcite as well.
Describe Manual Test Plan
I compare results with Postgres on some test queries.
Checklist