Merged
Conversation
mythical-fred
approved these changes
Mar 10, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. Clean rebase of the closed #5759 (which Gerd had approved). The check-prior-build job is designed to never fail (all steps are continue-on-error / if: always()), so no cancel sentinel needed — correctly noted. All downstream jobs gate on result == 'success' || result == 'skipped' so the skip path is properly handled.
0b0244e to
dcfe7d4
Compare
dcfe7d4 to
bbaa984
Compare
gz
approved these changes
Mar 11, 2026
.github/workflows/ci.yml
Outdated
| artifacts_run_id: ${{ steps.result.outputs.artifacts_run_id }} | ||
| skip_docker: ${{ steps.result.outputs.skip_docker }} | ||
| steps: | ||
| - name: Find prior run with all build artifacts for this commit |
Contributor
There was a problem hiding this comment.
It might be good to make this a dedicated step with a composite action. the inputs are a list of artifacts you require and the step passes or fails wether the artifacts are there or not
f4d44c7 to
2cbc7bc
Compare
gz
approved these changes
Mar 12, 2026
2cbc7bc to
8a1356e
Compare
Add a check-prior-build job to ci.yml that queries the GitHub API for a prior run on the same commit SHA. If all required binary and Docker digest artifacts are found unexpired, the Rust, Java, and Docker build jobs are skipped and test workflows download artifacts from that prior run instead of rebuilding from scratch. Each test workflow now accepts an artifacts_run_id input passed through from ci.yml, and uses it as the run-id in actions/download-artifact so cross-run artifact fetches work with the built-in action and no third-party dependencies. Build jobs that are skipped leave result=skipped (not failure), so sentinel cancel jobs and the final main job are unaffected.
8a1356e to
fc8fe9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check-prior-build job to ci.yml that queries the GitHub API for a prior run on the same commit SHA. If all required binary and Docker artifacts are found unexpired, the Rust, Java, and Docker build jobs are skipped and test workflows download artifacts from that prior run instead of rebuilding from scratch.
Each test workflow now accepts an artifacts_run_id input passed through from ci.yml, and uses it as run-id in actions/download-artifact so cross-run artifact fetches work with the built-in action.
Validated in feldera/feldera-ci-test: Run 1 built everything and passed; Run 2 skipped all build phases and reused artifacts from Run 1.
Fixes: #5531