Skip to content

[SQL] Fix typo in implementation of DROP#5781

Merged
mihaibudiu merged 1 commit intomainfrom
drop
Mar 9, 2026
Merged

[SQL] Fix typo in implementation of DROP#5781
mihaibudiu merged 1 commit intomainfrom
drop

Conversation

@mihaibudiu
Copy link
Contributor

Describe Manual Test Plan

Reran the SLT tests that failed overnight manually.

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@mihaibudiu mihaibudiu requested a review from snkas March 9, 2026 17:32
@mihaibudiu mihaibudiu enabled auto-merge March 9, 2026 17:32
@mihaibudiu mihaibudiu requested a review from lalithsuresh March 9, 2026 17:39
@mihaibudiu
Copy link
Contributor Author

We only implemented DROP so that we can run SLT, it is not really something we expect users to write in their pipelines.
That's why SLT is the only set of tests that exercises this.

@mihaibudiu mihaibudiu added this pull request to the merge queue Mar 9, 2026
Copy link

@mythical-fred mythical-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into main with commit 19a69ae Mar 9, 2026
1 check passed
@mihaibudiu mihaibudiu deleted the drop branch March 9, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants