[WebConsole] Add a Bun version check to prevent building with unsupported version#5237
[WebConsole] Add a Bun version check to prevent building with unsupported version#5237Karakatiza666 wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a Bun version check to prevent building with unsupported versions and updates the support bundle filename to be more descriptive. The version check script ensures developers use Bun 1.3.3 or higher before running dev or build commands.
Key Changes:
- Added automated Bun version validation (minimum 1.3.3) that runs before dev/build
- Updated support bundle filename from
fda-bundle-*tofeldera-support-bundle-*
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
js-packages/web-console/scripts/check-bun-version.ts |
New script that validates Bun version against minimum requirement (1.3.3) |
js-packages/web-console/package.json |
Integrated version check into dev and build npm scripts |
js-packages/web-console/src/lib/compositions/usePipelineManager.svelte.ts |
Updated downloaded support bundle filename prefix |
| @@ -0,0 +1,32 @@ | |||
| #!/usr/bin/env bun | |||
There was a problem hiding this comment.
[nitpick] The shebang line should have a space after the hash-bang. The correct format is #! /usr/bin/env bun (with a space after #!).
| #!/usr/bin/env bun | |
| #! /usr/bin/env bun |
79e2cec to
020bc4a
Compare
020bc4a to
d51e99f
Compare
|
I need to find the cause of CI issue and will then merge. |
d51e99f to
2d75b17
Compare
…rted version Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
2d75b17 to
6f97925
Compare
mythical-fred
left a comment
There was a problem hiding this comment.
Nice addition. Actionable error message is good.
| try { | ||
| // Get current Bun version | ||
| const result = await $`bun --version`.text() | ||
| const currentVersion = result.trim() |
There was a problem hiding this comment.
Nit: you can get the current version directly via Bun.version (a runtime global) instead of spawning bun --version as a child process. Simpler, faster, and avoids the shell dependency:
const currentVersion = Bun.versionNo need to import $ at all — and no .trim() needed either.
Update the name of downloaded support bundle
