Added typecheck for the registry tags#282
Open
moupriyaroy25 wants to merge 1 commit intofeathr-ai:mainfrom
Open
Added typecheck for the registry tags#282moupriyaroy25 wants to merge 1 commit intofeathr-ai:mainfrom
moupriyaroy25 wants to merge 1 commit intofeathr-ai:mainfrom
Conversation
hangfei
reviewed
May 25, 2022
Collaborator
hangfei
left a comment
There was a problem hiding this comment.
Thanks for the PR. Could you add a few tests for this?
Also maybe test dicts that contains non-string objects, like {"apple":[list of things]}
Author
|
@hangfei Thanks for reviewing. While I am trying to run the tests I am facing some issues during the installation of feathr module on my system. Here is the issue I have mentioned https://stackoverflow.com/questions/72316535/confluent-kafka-install-error-error-legacy-install-failure |
Author
|
@hangfei could you please also elaborate briefly about adding test dicts? Do I need to add any test files for this? I am still so new in this case so adding some links to reference docs might help me figure that out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changes to add type check for registry tags to check if registry_tags is a valid Dict[str, str] parameter.
the registry tags are in a dictionary format like this:
{"description":"this is a test feature"},so valid dictionary parameter.
and if the user does something like this
{"description", "this is a test feature"}, it'll also validate it.